Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master bug 1213132 ansible inventory #7596

Merged

Conversation

mikeletux
Copy link
Contributor

What does this PR change?

Port of https://github.com/SUSE/spacewalk/pull/22566

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: it is a bugfix for something it should've worked earlier.

  • DONE

Test coverage

  • Unit tests were added: AnsibleControllerTest.testParseInventoryAndGetHostnames

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/22065

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
Signed-off-by: Miguel Sama <miguel.sama@suse.com>
@mikeletux mikeletux requested a review from a team as a code owner September 27, 2023 14:46
@mikeletux mikeletux requested review from wweellddeerr and removed request for a team September 27, 2023 14:46
@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request
  • srv_rename_hostname
  • allcli_sanity
  • srv_monitoring
  • proxy_branch_network
  • min_ansible_control_node
  • proxy_cobbler_pxeboot
  • minssh_ansible_control_node

@mikeletux mikeletux requested review from lucidd and mackdk and removed request for wweellddeerr September 27, 2023 15:43
@mikeletux mikeletux merged commit b98e12f into uyuni-project:master Oct 2, 2023
@mikeletux mikeletux deleted the master-bug-1213132-ansible-inventory branch October 2, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant