Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25124 enforcing password requirements #9423

Merged

Conversation

Serp1co
Copy link
Contributor

@Serp1co Serp1co commented Oct 31, 2024

What does this PR change?

Enforce password requirement for server users, comes with a new admin panel to manage local users password policy.

GUI diff

Before:
uyuni-beofre

After:
uyuni-after
image

  • DONE

Documentation

Test coverage

  • Unit tests were added

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/25124
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql" (Test skipped, there are no changes to test)
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests" (Test skipped, there are no changes to test)

Before you merge

Check How to branch and merge properly!

@Serp1co Serp1co requested review from a team as code owners October 31, 2024 11:07
@Serp1co Serp1co requested review from cbbayburt and removed request for a team October 31, 2024 11:07
Copy link
Contributor

github-actions bot commented Oct 31, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9423/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9423/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@bisht-richa
Copy link
Contributor

bisht-richa commented Jan 13, 2025

UI looks good. Just two things:

  • Align buttons to the form elements column
  • Only Save button should be btn-primary please change Reset button to btn-default

Screenshot 2025-01-13 at 11 40 08**

Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found 2 cases of using "getConfig('max_passwd_len')"

  • java/code/src/com/suse/manager/webui/controllers/login/LoginController.java
  • java/code/webapp/WEB-INF/pages/common/fragments/user/user_attribute_sizes.jspf

In the last file also "min_passwd_len" is used as well.

Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion about to change a header. But the rest of the java and DB changes looks good

@@ -0,0 +1,190 @@
/*
* Copyright (c) 2014 Red Hat, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2014 Red Hat, Inc.
* Copyright (c) 2025 SUSE LLC

@Serp1co Serp1co merged commit 5bb9d7c into uyuni-project:master Feb 12, 2025
30 of 31 checks passed
Comment on lines +64 to +73
if CFG.has_key("server.min_passwd_len"):
move_configuration(
"PSW_CHECK_LENGTH_MIN",
CFG.max_passwd_len,
oldkey="server.min_passwd_len",
)
elif CFG.has_key("min_passwd_len"):
move_configuration(
"PSW_CHECK_LENGTH_MIN", CFG.min_passwd_len, oldkey="min_passwd_len"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be reviewed.
I think we need to use it on uppercase, so CFG.MIN_PASSWD_LEN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants