Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

29 add comments to location riddle component #37

Merged
merged 12 commits into from
Apr 28, 2024
Merged

29 add comments to location riddle component #37

merged 12 commits into from
Apr 28, 2024

Conversation

flyingbeat
Copy link
Contributor

No description provided.

flyingbeat added 10 commits April 22, 2024 18:09
@flyingbeat
frontend #29: adds custom styling for sheet modal
efc8e91
@flyingbeat
frontend #29: adjusts location riddle model to backend changes
5dc1075
@flyingbeat
frontend #29: adds comments modal to location riddle component
9ee3eb9
@flyingbeat
Merge branch '33-refactor-riddles' into 29-add-comments-to-location-r…
c83e27b 
…iddle-component
@flyingbeat
frontend #29: fix height of sheet modal to 50%
2652f1e
@flyingbeat
frontend #29: convert created_at from seconds to milliseconds in loca…
efd9426 
…tion-riddle-api.service.ts
@flyingbeat
frontend #29: add comments to location-riddle-post
7f529c9
@flyingbeat
frontend #29: refactor location-riddle-post component to expect a loc…
3903bd9 
…ationRiddle as input instead of each attribute separate
@flyingbeat
Merge branch 'develop' into 29-add-comments-to-location-riddle-component
c46c4e8
@flyingbeat
frontend #29: add functionality to post comment on location riddles
bbffdd6
@flyingbeat flyingbeat linked an issue Apr 27, 2024 that may be closed by this pull request
comment on location riddles uzh-ase-fs24/workspace#20
Closed
1 task
@flyingbeat flyingbeat requested a review from chrsBa April 27, 2024 09:55
@flyingbeat flyingbeat linked an issue Apr 27, 2024 that may be closed by this pull request
add comments to location riddle component #29
Closed
chrsBa
chrsBa approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@chrsBa chrsBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@flyingbeat flyingbeat merged commit 77cc41d into develop Apr 28, 2024
1 check passed
@flyingbeat flyingbeat deleted the 29-add-comments-to-location-riddle-component branch April 28, 2024 08:52
@flyingbeat flyingbeat removed a link to an issue May 10, 2024
comment on location riddles uzh-ase-fs24/workspace#20
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrsBa chrsBa chrsBa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add comments to location riddle component
2 participants
@flyingbeat @chrsBa