Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically award live session achievements for first, second and third rank #3886

Closed
wants to merge 8 commits into from

Conversation

sjschlapbach
Copy link
Member

No description provided.

Copy link
Member Author

@sjschlapbach sjschlapbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rschlaefli This PR should be basically ready, the only things left to do are:

  • seed the three achievements in the production DB and determine how many points / XP should be awarded for each achievement
  • include the IDs of the achievements in the production DB in the code

@sjschlapbach sjschlapbach marked this pull request as draft September 29, 2023 14:24
… database through the corresponding achievement information
@sjschlapbach sjschlapbach marked this pull request as ready for review September 29, 2023 14:28
@cypress
Copy link

cypress bot commented Sep 29, 2023

8 failed tests on run #1157 ↗︎

8 0 0 9 Flakiness 0

Details:

Merge db0f669 into c422a84...
Project: klicker-uzh Commit: 8639b9bab3 ℹ️
Status: Failed Duration: 02:51 💡
Started: Nov 9, 2023 3:41 PM Ended: Nov 9, 2023 3:44 PM
Failed  control-workflow.cy.ts • 1 failed test

View
Output

Test Artifacts
Test functionalities of frontend-control application > Test the basic functionalities of the control application: login and session management Test Replay Screenshots
Failed  learning-element-workflow.cy.ts • 1 failed test

View
Output

Test Artifacts
Different learning element workflows > creates and publishes a learning element Test Replay Screenshots
Failed  live-session-workflow.cy.ts • 1 failed test

View
Output

Test Artifacts
Different live-session workflows > adds and then deletes a second question block Test Replay Screenshots
Failed  login-workflow.cy.ts • 3 failed tests

View
Output

Test Artifacts
Login / Logout workflows for lecturer and students > signs in into student account Test Replay Screenshots
Login / Logout workflows for lecturer and students > signs in into student account on mobile Test Replay Screenshots
Login / Logout workflows for lecturer and students > signs in into lecturer account Test Replay Screenshots
Failed  micro-session-workflow.cy.ts • 1 failed test

View
Output

Test Artifacts
Different micro-session workflows > creates and publishes a micro session that should be visible to students Test Replay Screenshots

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #3886 ↗︎

Copy link
Member

@rschlaefli rschlaefli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See TODOs in code

@rschlaefli rschlaefli marked this pull request as draft October 28, 2023 15:20
@sjschlapbach
Copy link
Member Author

PR has been replaced with PR #3940

@sjschlapbach sjschlapbach deleted the AchievementsLiveSession branch November 9, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants