Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: introduce types package, switch to rollup build, update dependencies, fix types #4317

Merged
merged 50 commits into from
Oct 20, 2024
Merged

chore: introduce types package, switch to rollup build, update dependencies, fix types #4317

merged 50 commits into from
Oct 20, 2024

Conversation

sjschlapbach
Copy link
Member

@sjschlapbach sjschlapbach commented Oct 17, 2024 •
edited
Loading

No description provided.

@aviator-app Aviator app
Copy link

aviator-app bot commented Oct 17, 2024 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@cypress Cypress
Copy link

cypress bot commented Oct 17, 2024 •
edited
Loading

klicker-uzh    Run #3326

Run Properties:  status check passed Passed #3326  •  git commit 827b228bc1 ℹ️: Merge 1c6c2320acec3d5cc472093940d92eef98d0899a into 53bf3ccd8ebc2c029b944431b052...
Project klicker-uzh
Run status status check passed Passed #3326
Run duration 11m 00s
Commit git commit 827b228bc1 ℹ️: Merge 1c6c2320acec3d5cc472093940d92eef98d0899a into 53bf3ccd8ebc2c029b944431b052...
Committer Julius Schlapbach
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 140

sjschlapbach and others added 18 commits October 17, 2024 23:37
@sjschlapbach
wip: start fixing frontend types
2827081
@sjschlapbach
wip: fix types in frontend-pwa
81814dd
@sjschlapbach
wip: fix type issues in backend-docker
7abd1b4
@sjschlapbach
wip: fix type errors in prisma package
d8ef5fc
@sjschlapbach
chore: separate questiondata and elementdata
f87ebaa
@sjschlapbach
wip: fix type errors in graphql backend except from live quiz
2111c00
@sjschlapbach
chore: remove unused code
7ada38f
@sjschlapbach
chore: resolve type error in backend docker
e8342b3
@sjschlapbach
wip: fix type issues in frontend-manage
7408392
@sjschlapbach @rschlaefli
chore: move custom type definitions from graphql package to util pack…
a3a554b 
…age to be available in helper functions (#4318)

Co-authored-by: Roland Schläfli <rolandschlaefli@gmail.com>
@sjschlapbach
wip: continue fixing types
2552aac
@rschlaefli
instrumented as root dir in tests
68d8ce2
@rschlaefli
instrumented should also be in tsconfig
82fa5dc
@sjschlapbach
refactor: use union types for element data, question data and evaluat…
df73ee5 
…ion results (#4320)
@sjschlapbach
chore: update ts config
36adc7f
@sjschlapbach
fix: resolve type issues connected to react-dnd and next
b28c358
@sjschlapbach
fix: resolve type issue connected to initial sample solution type loa…
e2254ed 
…ding
@sjschlapbach
chore: resolve type issues caused by fakes instance for question prev…
81cbf87 
…iew (#4321)
@sjschlapbach sjschlapbach changed the title [WIP] chore: fix type errors [WIP] chore: fix all remaining typescript errors Oct 19, 2024
@sjschlapbach
chore: add prisma types package dependency for successful typing
9db13ef
@sjschlapbach
chore: ignore instrumented folder in backend-docker for types checkin…
e8f750d 
…g (auto-generated)
@sjschlapbach
chore: undo ts config change
299af59
@sjschlapbach
chore: switch back to normal build command
7522d9a
@sjschlapbach
chore: typecasting to resolve wrong type error in data table
ad80286
@sjschlapbach
modify ci action to only build relevant packages
969fb13
@sjschlapbach
chore: remove old ci action job
ef84a52
@sjschlapbach
chore: downgrade remark-math
2f64f69
@sjschlapbach
chore: upgrade remark-math in docs again for build success
b4d1061
@sjschlapbach
Merge branch 'v3' of https://github.com/uzh-bf/klicker-uzh into fix-f…
cbe2c00 
…rontend-types
@sjschlapbach
Merge branch 'v3' of https://github.com/uzh-bf/klicker-uzh into fix-f…
aa04910 
…rontend-types
@sjschlapbach
chore: update remark math in docs
ac09134
@sjschlapbach
wip: resolve ambiguous types through graphql type information
c15a58f
@sjschlapbach sjschlapbach changed the base branch from v3 to v3-types October 20, 2024 19:16
@sjschlapbach sjschlapbach changed the title [WIP] chore: fix all remaining typescript errors chore: introduce types package, switch to rollup build, update dependencies, fix types Oct 20, 2024
@sjschlapbach sjschlapbach marked this pull request as ready for review October 20, 2024 19:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sjschlapbach sjschlapbach merged commit 6f5cb21 into v3-types Oct 20, 2024
21 of 26 checks passed
@sjschlapbach sjschlapbach deleted the fix-frontend-types branch October 20, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjschlapbach @rschlaefli