-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate live quiz to element block and element instances #4338
base: v3
Are you sure you want to change the base?
Conversation
…ting (#4337) Co-authored-by: Roland Schläfli <rolandschlaefli@gmail.com>
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 172 files out of 300 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
klicker-uzh Run #3673
Run Properties:
|
Project |
klicker-uzh
|
Branch Review |
v3-new-live-quiz
|
Run status |
Passed #3673
|
Run duration | 11m 30s |
Commit |
c06d0040c1: Merge branch 'v3' of https://github.com/uzh-bf/klicker-uzh into v3-new-live-quiz
|
Committer | sjschlapbach |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
140
|
View all changes introduced in this branch ↗︎ |
klicker-uzh Run #3674
Run Properties:
|
Project |
klicker-uzh
|
Branch Review |
v3-new-live-quiz
|
Run status |
Passed #3674
|
Run duration | 11m 37s |
Commit |
62648bcbc4 ℹ️: Merge c06d0040c11c3a88fa3ebd2aba1c6beafa93aaef into 349ce8ae1b11106c0ec037b4485f...
|
Committer | Julius Schlapbach |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
140
|
View all changes introduced in this branch ↗︎ |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
1623504 | Triggered | Username Password | 761360a | deploy/compose-traefik-proxy/klicker/services.env | View secret |
1509424 | Triggered | Generic Password | 761360a | docker-compose.yml | View secret |
1509424 | Triggered | Generic Password | 761360a | deploy/compose/docker-compose.yml | View secret |
1509424 | Triggered | Generic Password | 761360a | deploy/compose/docker-compose.yml | View secret |
1509424 | Triggered | Generic Password | c06d004 | util/_restore-db.sh | View secret |
1509424 | Triggered | Generic Password | c06d004 | util/_restore-db.sh | View secret |
1509424 | Triggered | Generic Password | c06d004 | docker-compose.yml | View secret |
1509424 | Triggered | Generic Password | c06d004 | util/_restore-db.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
DO NOT SQUASH THIS BRANCH ON MERGE - development branch for live quiz migration
Before / after merging and applying this branch, execute the following steps: