Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate live quiz to element block and element instances #4338

Open
wants to merge 25 commits into
base: v3
Choose a base branch
from

Conversation

sjschlapbach
Copy link
Member

@sjschlapbach sjschlapbach commented Oct 28, 2024

DO NOT SQUASH THIS BRANCH ON MERGE - development branch for live quiz migration

Before / after merging and applying this branch, execute the following steps:

  • Test that all functionalities of live quiz (including sessions with time limit, element instance updates, etc.) work correctly
  • Verify that variable point logic (timeToZeroBonus and maxBonusPoints) still works as it should
  • Migration script should: copy group activity status to new status, copy element stack type to new type, migrate QuestionInstance to ElementInstance, migrate SessionBlock to ElementBlock, migrate LiveSession to LiveQuiz
  • After migration: Remove QuestionInstance, SessionBlock, LiveSession, rename new group activity status to old one and drop old enum, rename new element stack type to old one and drop old column, (drop originalId columns?!)
  • Create database dump to avoid any potential data loss
  • Apply all database migrations

…ting (#4337)

Co-authored-by: Roland Schläfli <rolandschlaefli@gmail.com>
Copy link

aviator-app bot commented Oct 28, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link

coderabbitai bot commented Oct 28, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

172 files out of 300 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cypress bot commented Oct 28, 2024

klicker-uzh    Run #3673

Run Properties:  status check passed Passed #3673  •  git commit c06d0040c1: Merge branch 'v3' of https://github.com/uzh-bf/klicker-uzh into v3-new-live-quiz
Project klicker-uzh
Branch Review v3-new-live-quiz
Run status status check passed Passed #3673
Run duration 11m 30s
Commit git commit c06d0040c1: Merge branch 'v3' of https://github.com/uzh-bf/klicker-uzh into v3-new-live-quiz
Committer sjschlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 140
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Oct 28, 2024

klicker-uzh    Run #3674

Run Properties:  status check passed Passed #3674  •  git commit 62648bcbc4 ℹ️: Merge c06d0040c11c3a88fa3ebd2aba1c6beafa93aaef into 349ce8ae1b11106c0ec037b4485f...
Project klicker-uzh
Branch Review v3-new-live-quiz
Run status status check passed Passed #3674
Run duration 11m 37s
Commit git commit 62648bcbc4 ℹ️: Merge c06d0040c11c3a88fa3ebd2aba1c6beafa93aaef into 349ce8ae1b11106c0ec037b4485f...
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 140
View all changes introduced in this branch ↗︎

Copy link

gitguardian bot commented Nov 6, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
1623504 Triggered Username Password 761360a deploy/compose-traefik-proxy/klicker/services.env View secret
1509424 Triggered Generic Password 761360a docker-compose.yml View secret
1509424 Triggered Generic Password 761360a deploy/compose/docker-compose.yml View secret
1509424 Triggered Generic Password 761360a deploy/compose/docker-compose.yml View secret
1509424 Triggered Generic Password c06d004 util/_restore-db.sh View secret
1509424 Triggered Generic Password c06d004 util/_restore-db.sh View secret
1509424 Triggered Generic Password c06d004 docker-compose.yml View secret
1509424 Triggered Generic Password c06d004 util/_restore-db.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sjschlapbach sjschlapbach marked this pull request as ready for review November 10, 2024 11:03
@rschlaefli rschlaefli changed the title refactor: migrate live quiz to element stack and element instances refactor: migrate live quiz to element block and element instances Nov 10, 2024
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
5.9% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants