Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/82 extend usage of context #13

Merged
merged 13 commits into from
Oct 25, 2022
Merged

Feature/82 extend usage of context #13

merged 13 commits into from
Oct 25, 2022

Conversation

timohuber
Copy link
Contributor

@timohuber timohuber commented Oct 17, 2022 •
edited
Loading

I added the following user to the context:

type user =
  | Admin of Sihl_user.t
  | Contact of Contact.t
  | Root of Sihl_user.t

I used Sihl_user.t as a placeholder for Admin.t until guardian is implemented.

@timohuber timohuber requested a review from aronerben October 18, 2022 14:27
aronerben
aronerben suggested changes Oct 21, 2022
View reviewed changes
@timohuber
Copy link
Contributor Author

@aronerben ping

@aronerben
Copy link
Contributor

There are merge conflicts @timohuber

@aronerben aronerben merged commit d9328a1 into main Oct 25, 2022
@timohuber timohuber deleted the feature/82-extend-usage-of-context branch February 23, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aronerben aronerben aronerben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timohuber @aronerben