Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: improve grammar, better MD structure & fix some code #41

Merged
merged 10 commits into from
Nov 3, 2019
Merged

examples: improve grammar, better MD structure & fix some code #41

merged 10 commits into from
Nov 3, 2019

Conversation

dhonx
Copy link
Member

@dhonx dhonx commented Nov 1, 2019

No description provided.

@dhonx dhonx added the documentation Improvements or additions to documentation label Nov 1, 2019
@dhonx dhonx requested review from vbrazo and Delta456 November 1, 2019 06:56
@dhonx dhonx self-assigned this Nov 1, 2019
Delta456
Delta456 requested changes Nov 1, 2019
View reviewed changes
examples/arrays/functions.md Outdated Show resolved Hide resolved
examples/functions/functions.md Show resolved Hide resolved
vbrazo
vbrazo approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except the html comment that should be replaced for a V comment.

Thanks for fixing all the grammar issues and details 💥

@vbrazo vbrazo requested a review from Delta456 November 1, 2019 16:27
@Delta456 Delta456 merged commit df47658 into v-community:master Nov 3, 2019
@dhonx dhonx deleted the patch-23ecb65c branch November 4, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

@Delta456 Delta456 Delta456 approved these changes

Assignees

@dhonx dhonx

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhonx @vbrazo @Delta456