Deprecate PWC-Net, change env name to 'video_features', update .gitignore #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convinced myself to deprecate PWC-Net. the implementation of it taxed me for a very long time and people were reporting problems with it #13 #6 #8.
the list goes a long way, to name a few considerations:
a) it requires a separate conda environment,
b) it depends on
cupy
that is difficult to maintain,c) current implementation does not support newer GPUs,
d) RAFT is a better alternative,
e) the implementation that I used is licensed as GPL which makes the whole library to be GPL.
overall, it is not worth the effort to maintain it. it's time to move on, I am afraid.
another change that this PR brings is the environment name:
torch_zoo
-->video_features
TODO: