Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PWC-Net, change env name to 'video_features', update .gitignore #112

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

v-iashin
Copy link
Owner

@v-iashin v-iashin commented Jan 20, 2024

convinced myself to deprecate PWC-Net. the implementation of it taxed me for a very long time and people were reporting problems with it #13 #6 #8.

the list goes a long way, to name a few considerations:
a) it requires a separate conda environment,
b) it depends on cupy that is difficult to maintain,
c) current implementation does not support newer GPUs,
d) RAFT is a better alternative,
e) the implementation that I used is licensed as GPL which makes the whole library to be GPL.

overall, it is not worth the effort to maintain it. it's time to move on, I am afraid.

another change that this PR brings is the environment name: torch_zoo --> video_features

TODO:

  • remove the figure from the gif, draw io, and from toc in docs (but keep the page)
  • run the tests
  • fix typos
  • fix license
  • give a user an error pointing to this pr if they specify pwc as optical flow

@v-iashin v-iashin changed the title Depricate PWC-Net, change env name to 'video_features', update .gitignore Deprecate PWC-Net, change env name to 'video_features', update .gitignore Jan 20, 2024
@v-iashin v-iashin merged commit 40c3f29 into master Jan 20, 2024
@v-iashin v-iashin deleted the pwc/rm branch January 21, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant