implement nip57 with suggested modifications #256
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements modifications suggested on nostr-protocol/nips#224 (comment) while retaining backwards-compatibility (although I think it should not retain that).
I wasn't able to test it yet because I don't have a compatible server (I was turning https://github.com/nbd-wtf/satdress into a zap-compatible server but realized that that will be very hard because currently it cannot know when an invoice was paid), so maybe it is broken.
For now, I'm leaving here just as an exercise.