Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement nip57 with suggested modifications #256

Closed
wants to merge 2 commits into from

Conversation

fiatjaf
Copy link
Contributor

@fiatjaf fiatjaf commented Feb 11, 2023

This implements modifications suggested on nostr-protocol/nips#224 (comment) while retaining backwards-compatibility (although I think it should not retain that).

I wasn't able to test it yet because I don't have a compatible server (I was turning https://github.com/nbd-wtf/satdress into a zap-compatible server but realized that that will be very hard because currently it cannot know when an invoice was paid), so maybe it is broken.

For now, I'm leaving here just as an exercise.

@v0l
Copy link
Owner

v0l commented Feb 11, 2023

I implemented the new zaps flow api already in snort donate, ill push it later to test

@v0l
Copy link
Owner

v0l commented Feb 11, 2023

Ok its live now, you can try use the new zaps flow here: https://api.snort.social/swagger/index.html

Payment status is only checked in background job so it will take about 2mins to see receipt

@fiatjaf
Copy link
Contributor Author

fiatjaf commented Feb 12, 2023

Thank you. I can only try this tomorrow, will proceed from there.

@v0l
Copy link
Owner

v0l commented Feb 12, 2023

Thank you. I can only try this tomorrow, will proceed from there.

I already tried it out, i implemented it differently on the API

POST /zap returns something similar to LNURL endpoint:

{ "pr": "lnbc1..." }

I also implement the same status response as LNURL

@fiatjaf
Copy link
Contributor Author

fiatjaf commented Feb 12, 2023

You mean the status: "ERROR" and the reason string? OK, that sounds good to me.

@v0l
Copy link
Owner

v0l commented Feb 12, 2023

Yep, pushed the changes, I got as far as making zaps but they are not showing in the UI

@fiatjaf fiatjaf closed this Feb 13, 2023
@fiatjaf fiatjaf deleted the nip57-v2 branch February 13, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants