Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shanbay.com leangoo.com #439

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Add shanbay.com leangoo.com #439

merged 1 commit into from
Mar 5, 2021

Conversation

4piu
Copy link
Contributor

@4piu 4piu commented Mar 4, 2021

No description provided.

@IceCodeNew
Copy link
Collaborator

单独的域名可以不用新建一个文件,直接写在 geolocation-cn 下。

Copy link
Collaborator

@IceCodeNew IceCodeNew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如上。
另外其实扇贝分类在工具书下也不是特别合适

@4piu
Copy link
Contributor Author

4piu commented Mar 5, 2021

Thank you for the feedback. I will modify this PR accordingly.

单独的域名可以不用新建一个文件,直接写在 geolocation-cn 下。

There are many entry files under /data with only one domain, while geolocation-cn has a blob of uncategorized domain list. After following the discussion in #28 , I am still unclear of how the new record should be added, especially for the site with single domain.

如上。
另外其实扇贝分类在工具书下也不是特别合适

Any suggestions?

@IceCodeNew
Copy link
Collaborator

IceCodeNew commented Mar 5, 2021

单独的域名可以不用新建一个文件,直接写在 geolocation-cn 下。

There are many entry files under /data with only one domain, while geolocation-cn has a blob of uncategorized domain list. After following the discussion in #28 , I am still unclear of how the new record should be added, especially for the site with single domain.

#259 (comment)

这些仅包含 1 条规则的列表文件不但没有为 geolocation-cn 或其他 categorys 减轻维护负担,反而影响了维护。
单独为几条规则创建一个新的列表文件并不能有效减少 geolocation-cn 的规则条数,因为你还需要 include: NAME。
按照以上的统计信息,我建议所包含规则条数小于 5 的公司/组织不要为其创建单独的列表文件。

#256 (comment)

其实大部分只有一两个域名的列表是我引入的,当时也没考虑太多。但是现在列表多了之后,反而导致了生成文件的无谓增大;以及 data 目录超过 1000 个条目,无法全部看到。

@IceCodeNew IceCodeNew merged commit 70191f8 into v2fly:master Mar 5, 2021
github-actions bot added a commit to YW5vbnltb3Vz/domain-list-community that referenced this pull request Mar 5, 2021
* https://github.com/v2fly/domain-list-community:
  Include cdn77 into geolocation-!cn (v2fly#453)
  Include joox.com into category-entertainment (v2fly#451)
  Update category-porn (v2fly#452)
  Update spotify (v2fly#448)
  Update kkbox (v2fly#449)
  Update verizon
  Add shanbay.com leangoo.com (v2fly#439)
  Update brightcove (v2fly#446)
  Update fox
  Update tvb (v2fly#445)
  Include limelight into geolocation-!cn (v2fly#442)
  Include intercom into geolocation-!cn (v2fly#444)
  Include dazn into category-entertainment (v2fly#443)
  Update bbc (v2fly#441)
  Update amazon (v2fly#440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants