Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the category of mihoyo #831

Merged
merged 8 commits into from
Apr 4, 2022
Merged

Split the category of mihoyo #831

merged 8 commits into from
Apr 4, 2022

Conversation

rootmelo92118
Copy link
Collaborator

Fixes #829

@rootmelo92118
Copy link
Collaborator Author

rootmelo92118 commented Apr 3, 2022 •
edited
Loading

The location of honkaistarrail.com is in Hong Kong Special Administrative Region. I also move it into hoyoverse.

@rootmelo92118 rootmelo92118 changed the title Spilt category of mihoyo Split category of mihoyo Apr 3, 2022
@rootmelo92118 rootmelo92118 changed the title Split category of mihoyo Split the category of mihoyo Apr 3, 2022
IceCodeNew
IceCodeNew requested changes Apr 3, 2022
View reviewed changes
data/category-entertainment Outdated Show resolved Hide resolved
@IceCodeNew
Copy link
Collaborator

A great proposal. Just need a slite change.

@rootmelo92118
Copy link
Collaborator Author

rootmelo92118 commented Apr 3, 2022 •
edited
Loading

A great proposal. Just need a slite change.

如果我直接引用mihoyo，他會連著mihoyo-cn一起包進來，然而mihoyo-cn中的內容是米哈游在中國大陸服務的網址，但是category-entertainment 僅收錄大陸以外的娛樂網站，所以我認為應該引用僅包含海外服務的hoyoverse ，而不是mihoyo。

@IceCodeNew
Copy link
Collaborator

IceCodeNew commented Apr 4, 2022 •
edited
Loading

A great proposal. Just need a slite change.

如果我直接引用mihoyo，他會連著mihoyo-cn一起包進來，然而mihoyo-cn中的內容是米哈游在中國大陸服務的網址，但是category-entertainment 僅收錄大陸以外的娛樂網站，所以我認為應該引用僅包含海外服務的hoyoverse ，而不是mihoyo。

这个问题应该在列表生成逻辑上修复，而不是扭曲列表的从属关系
你可以试试 https://github.com/Loyalsoldier/domain-list-custom 这个项目，应该能解决你说的问题。
image

@rootmelo92118
Copy link
Collaborator Author

rootmelo92118 commented Apr 4, 2022 •
edited
Loading

A great proposal. Just need a slite change.

如果我直接引用mihoyo，他會連著mihoyo-cn一起包進來，然而mihoyo-cn中的內容是米哈游在中國大陸服務的網址，但是category-entertainment 僅收錄大陸以外的娛樂網站，所以我認為應該引用僅包含海外服務的hoyoverse ，而不是mihoyo。

这个问题应该在列表生成逻辑上修复，而不是扭曲列表的从属关系 你可以试试 https://github.com/Loyalsoldier/domain-list-custom 这个项目，应该能解决你说的问题。 image

知道了，已更正完畢

IceCodeNew
IceCodeNew requested changes Apr 4, 2022
View reviewed changes
data/category-entertainment Outdated Show resolved Hide resolved
@IceCodeNew IceCodeNew merged commit 4d69222 into v2fly:master Apr 4, 2022
@IceCodeNew
Copy link
Collaborator

Thanks for your contribution!

@rootmelo92118 rootmelo92118 deleted the patch-4 branch April 4, 2022 06:43
github-actions bot added a commit to YW5vbnltb3Vz/domain-list-community that referenced this pull request Apr 4, 2022
@github-actions
[bot] AutoMerging: merge all upstream's changes:
7558885 
* https://github.com/v2fly/domain-list-community:
  Split the category of mihoyo (v2fly#831)
@rootmelo92118 rootmelo92118 mentioned this pull request May 7, 2022
Closed
@rootmelo92118 rootmelo92118 mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceCodeNew IceCodeNew IceCodeNew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hoyoverse.com 及其子域名之歸屬
2 participants
@rootmelo92118 @IceCodeNew