fix(app/log): prevent close of closed channel #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 39.23% // Head: 39.20% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
- Coverage 39.23% 39.20% -0.03%
==========================================
Files 617 617
Lines 36833 36825 -8
==========================================
- Hits 14453 14439 -14
- Misses 20791 20793 +2
- Partials 1589 1593 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
AkinoKaede
approved these changes
Feb 3, 2023
The close of `done` channel may be called many times. And the handler will be blocked when the log client exists and the closure func is still not be called. So use context to resolve those two problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2282
The close of
donechannel may be called many times. And the handler will be blocked when the log client exists and the closure func is still not be called.So use context to resolve those two problems.