Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix protocol matching in routing #2540

Merged
merged 3 commits into from
Sep 14, 2023
Merged

fix protocol matching in routing #2540

merged 3 commits into from
Sep 14, 2023

Conversation

dyhkwong
Copy link
Contributor

protocol prefixes listed in document: http, tls, bittorrent

current possible protocols:
from sniffer: http1, http2(invalid value), tls, quic, bittorrent, fakedns
from http inbound: http/1.1 (matches http, incorrect if it has stream settings)
from internal dns: dns (TCP and UDP DNS), https (DoH, matches http instead of tls), quic (DoQ)

possible protocols after this change:
from sniffer: http1, tls, quic, bittorrent, fakedns
from internal dns: dns (TCP and UDP DNS), tls (DoH), quic (DoQ)

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.04 ⚠️

Comparison is base (262e9f1) 39.07% compared to head (f325cdb) 39.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2540      +/-   ##
==========================================
- Coverage   39.07%   39.03%   -0.04%     
==========================================
  Files         617      617              
  Lines       37047    37039       -8     
==========================================
- Hits        14475    14458      -17     
- Misses      20983    20988       +5     
- Partials     1589     1593       +4     
Impacted Files Coverage Δ
proxy/http/server.go 0.53% <0.00%> (+<0.01%) ⬆️
app/dns/nameserver_doh.go 67.60% <100.00%> (ø)
common/protocol/http/sniff.go 87.87% <100.00%> (+7.87%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AkinoKaede AkinoKaede requested a review from xiaokangwang May 28, 2023 00:19
@AkinoKaede AkinoKaede merged commit 8de2f27 into v2fly:master Sep 14, 2023
@dyhkwong dyhkwong deleted the protocol branch September 14, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants