Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): support to set permission for UDS and correctly close lock file #2596

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

yin1999
Copy link
Contributor

@yin1999 yin1999 commented Jul 9, 2023

Fixes: #2554.

This PR add support to set permission for UDS when set listen field like "listen": "/dev/shm/v2fly.sock,0666". And move the "close lock file" logic to system listen creator. As the previous logic would never close and remove the lock file (the parent context could not got the value set by child).

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2023

Codecov Report

Patch coverage: 11.76% and project coverage change: -0.03% ⚠️

Comparison is base (5c995d9) 38.29% compared to head (c20e126) 38.27%.
Report is 10 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2596      +/-   ##
==========================================
- Coverage   38.29%   38.27%   -0.03%     
==========================================
  Files         637      637              
  Lines       38122    38153      +31     
==========================================
+ Hits        14599    14602       +3     
- Misses      21911    21944      +33     
+ Partials     1612     1607       -5     
Files Changed Coverage Δ
transport/internet/grpc/hub.go 3.12% <ø> (+0.13%) ⬆️
transport/internet/http/hub.go 56.03% <ø> (+2.31%) ⬆️
transport/internet/tcp/hub.go 50.00% <ø> (+3.62%) ⬆️
transport/internet/transportcommon/listener.go 0.00% <0.00%> (ø)
transport/internet/websocket/hub.go 58.33% <ø> (+2.88%) ⬆️
transport/internet/system_listener.go 34.66% <13.33%> (-13.42%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yin1999 yin1999 changed the title fix(transport): allow to set permission for UDS and correctly close lock file fix(transport): support to set permission for UDS and correctly close lock file Jul 9, 2023
@AkinoKaede AkinoKaede requested a review from xiaokangwang July 9, 2023 08:25
Copy link
Contributor

@xiaokangwang xiaokangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This merge request is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting permission for domain socket file
3 participants