Add stats counter for outbounds #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields will be used by Outbounds as well in the next commit
|
Thanks for your review! I added a line of comment based on Codacy review. Not sure about the other test failures. But I checked the test I added is running successfully. |
xiaokangwang
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2ray has a great design to create both client and server from one project. However, the current traffic stats can only be measured from the inbounds. This is ok for server but not very useful for the client. On the client side, user want to know how much traffic went through freedom, how much went through proxy, and which node.
Currently it only works for TCP. I think it cover most of the use case. Once approved I will work to add UDP support.It works for TCP as well as UDP. I've tested this code for measuring vmess (tcp, wss, mkcp) and freedom outbound.
I'm new to this project. I'm a contributor for v2rayNG. Please kindly review my code :)