Fake DNS with full V2 intergration #406

xiaokangwang · 2020-11-11T10:26:54Z

This is a more integrated version of #395 by @yuhan6665 .
Fake DNS Pool will be represented as a Instance Service, and the match and replace process will be considered a sniffer.

Following new project interface have been added:
Metadata sniffer, which is used to sniff connection data from metadata, instead of content.
Configure file post processing stage, which is used to add candy or lint to configure file.

yuhan6665 · 2020-11-11T13:41:51Z

@xiaokangwang 👍 I can do some test on Android device, today or tomorrow.
I briefly looked through the commits. I'll need to add "sniffing" : "destOverride": [ "fakedns" ] in the inbound. And you added a config object at the root level? In that case we can remove the "fake" object in "dns" right?

xiaokangwang · 2020-11-11T13:54:45Z

@xiaokangwang +1 I can do some test on Android device, today or tomorrow.
I briefly looked through the commits. I'll need to add "sniffing" : "destOverride": [ "fakedns" ] in the inbound. And you added a config object at the root level? In that case we can remove the "fake" object in "dns" right?

Here is a working configure file
https://gist.github.com/xiaokangwang/17fd100bca6bbb22b9ca110919bfed0d

No, you still need to add a fake boolean value in the DNS, and the FakeDNS top level setting is optional.

xiaokangwang · 2020-11-11T13:57:11Z

There are some report that sometimes Fake IP cannot be picked up by Fake DNS and will be allocated a new IP or unable to rewrite domain. I am still investigating.

yuhan6665 · 2020-11-12T04:51:48Z

Did some test. I found no issue on my side except the "fakeDns" top level setting is not taking effect.

xiaokangwang · 2020-11-12T11:17:38Z

I have fixed a issue prevent UDP socket with fake DNS IP from restored to original domain name.

xiaokangwang · 2020-11-12T11:35:38Z

Did some test. I found no issue on my side except the "fakeDns" top level setting is not taking effect.

I think I have fixed this in the 0a94cfd . Please let me know if it is not fixed for you.

app/dns/fake.go

rurirei · 2020-11-13T09:15:24Z

sorry for simple suggestion of final configuration without code review

  // remove
  "dns": {
      "fake": true
  },

  // remove
      {
        "type": "field",
        "ip": [
          "240.0.0.0/8"
        ],
        "outboundTag": "discard"
      }

  // remove
      {
        "type": "field",
        "port": "53",
        "outboundTag": "fakedns"
      },

  // remove
    {
      "protocol": "dns",
      "settings": {
      },
      "tag": "fakedns"
    },

  // makes the similar experience of v2ray-sniffing
      "sniffing": {
        "enabled": true,
        "destOverride": [
       // "http, tls",
          "fakedns"  // specify fakeDns and routing-dns
        ],
        "range": "240.0.0.0/8",  // specify fake-range and routing-discard
        "metadataOnly": true
      }

kslr · 2020-12-02T12:08:03Z

any update?

xiaokangwang · 2020-12-04T16:34:11Z

No, I am waiting for merge

xiaokangwang · 2020-12-16T20:15:14Z

Is this pr clear for merge?

Loyalsoldier · 2020-12-19T04:55:19Z

Could the fakeDNS configuration be simplified?

kslr · 2020-12-19T10:03:26Z

Now Don't merge

A new config object "fake" in DnsObject for toggling fake dns function Compare with sniffing, fake dns is not limited to http and tls traffic. It works across all inbounds. For example, when dns request come from one inbound, the local DNS server of v2ray will response with a unique fake IP for every unique domain name. Then later on v2ray received a request to one of the fake IP from any inbounds, it will override the request destination with the previously saved domain. By default, v2ray cache up to 65535 addresses. The old records will be discarded bases on LRU. The fake IP will be 240.x.x.x

…n the future.

…his will work for both IPv4 and IPv6 networks.

…e, it will create a infinite loop

xiaokangwang · 2021-01-27T17:08:09Z

I have rebased the code so that it do not have any merge conflict with master branch.

kslr · 2021-02-08T10:22:52Z

"fakedns": {
    "ipPool": "240.0.0.0/8",
    "poolSize": 65535
}

...

"sniffing": {
        "enabled": true,
        "destOverride": [
            "http",
            "tls",
            "fakedns"
        ],
        "metadataOnly": true
},

yuhan6665 · 2021-02-08T18:05:45Z

"fakedns": {
    "ipPool": "240.0.0.0/8",
    "poolSize": 65535
}

...

"sniffing": {
        "enabled": true,
        "destOverride": [
            "http",
            "tls",
            "fakedns"
        ],
        "metadataOnly": true
},

I haven't test the latest version. From look of this commit a1a4ab1
It is also needed to add fakedns in the DNS server list?

kslr · 2021-02-08T23:23:44Z

"fakedns": {
    "ipPool": "240.0.0.0/8",
    "poolSize": 65535
}

...

"sniffing": {
        "enabled": true,
        "destOverride": [
            "http",
            "tls",
            "fakedns"
        ],
        "metadataOnly": true
},
I haven't test the latest version. From look of this commit a1a4ab1
It is also needed to add fakedns in the DNS server list?

"dns": {
        "servers": [
            "fakedns"
            "8.8.8.8",
            "https://1.1.1.1/dns-query"
        ]
    },

p.s I am still looking for a more suitable config structure, Don't forget to express your opinion :)

yuhan6665 · 2021-02-09T00:24:48Z

The current config is good in general.
For fake ip -> domain, I'd like to add a small change for sniffer enhancement.
For domain -> fake ip, in the future if we want to add a whitelist or blacklist, I think the best structure is to create a "fakedns outbound". Then user can leverage the existing routing to configure any rule. Something like:

"fakedns": {
"ipPool": "240.0.0.0/8",
"poolSize": 65535
}
"dns": {} //normal dns
"outbounds": [
{
"protocol": "dns",
"tag": "dns"
},
{
"protocol": "fakedns",
"tag": "fakedns"
}
]
"routing": {
"rules": [
{
"outboundTag": "dns" // a black list that don't want to use fake dns
},
{
"outboundTag": "fakedns" // a white list that can use fake dns
},
{
"outboundTag": "dns" // send normal dns request
}
]
}

yuhan6665 · 2021-02-16T02:32:55Z

@xiaokangwang @kslr sorry for the late reply. I did test on Android and found some issue in the latest version. In 38e4107, the interface LookupFakeIP(domain string) is removed and fakedns become a standard client. This might be ok in some cases, but in Android, when a request is sent out from "Freedom", it will get the fake IP and fail. This is because VPN service take over all system DNS traffic and pass it to core.
I'm thinking of two possible fix: one is to add a new interface similar to LookupFakeIP(domain string) which makes the query from freedom outbound and routing ignore "fakedns". The second is add a new "fakedns" outbound. Thoughts?

rurirei · 2021-02-19T18:34:14Z

@xiaokangwang @kslr sorry for the late reply. I did test on Android and found some issue in the latest version. In 38e4107, the interface LookupFakeIP(domain string) is removed and fakedns become a standard client. This might be ok in some cases, but in Android, when a request is sent out from "Freedom", it will get the fake IP and fail. This is because VPN service take over all system DNS traffic and pass it to core.
I'm thinking of two possible fix: one is to add a new interface similar to LookupFakeIP(domain string) which makes the query from freedom outbound and routing ignore "fakedns". The second is add a new "fakedns" outbound. Thoughts?

former agreed.

Loyalsoldier · 2021-02-21T04:07:03Z

@xiaokangwang @kslr sorry for the late reply. I did test on Android and found some issue in the latest version. In 38e4107, the interface LookupFakeIP(domain string) is removed and fakedns become a standard client. This might be ok in some cases, but in Android, when a request is sent out from "Freedom", it will get the fake IP and fail. This is because VPN service take over all system DNS traffic and pass it to core.
I'm thinking of two possible fix: one is to add a new interface similar to LookupFakeIP(domain string) which makes the query from freedom outbound and routing ignore "fakedns". The second is add a new "fakedns" outbound. Thoughts?

Is this related to #572 and #692 ?

yuhan6665 · 2021-02-21T14:54:53Z

@Loyalsoldier these are different issues. #696 is to fix direct traffic send out from freedom outbound, when fake DNS is enabled.

xiaokangwang self-assigned this Nov 11, 2020

database64128 mentioned this pull request Nov 12, 2020

Selective ("smart") proxying Jigsaw-Code/outline-apps#887

Open

yuhan6665 reviewed Nov 13, 2020

View reviewed changes

app/dns/fake.go Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

kslr force-pushed the dev-fakedns branch from 9c870cd to f9e2fc1 Compare December 4, 2020 23:16

yuhan6665 and others added 12 commits January 27, 2021 16:54

fix an edge case when encounter a fake IP in use

419dc4d

Move lru to common.cache package

b8be7f7

Added the necessary change to obtain request IP from sniffer

2413578

Refactor the code so that it may stop depending on global variables i…

3a93518

…n the future.

Replace string manipulation code with more generic codes, hopefully t…

6373f75

…his will work for both IPv4 and IPv6 networks.

Try to use IPv4 version of address if possible

79c1a78

Added Test Case for Fake Dns

d1d40c2

Added More Test Case for Fake Dns

6c8bf8a

Stop user from creating a instance with LRU size more than subnet siz…

b0b9784

…e, it will create a infinite loop

Move Fake DNS to a separate package

cd1c815

Generated Code for fakedns

4b08316

xiaokangwang force-pushed the dev-fakedns branch from 6ad3760 to 1c909d6 Compare January 27, 2021 17:06

xiaokangwang requested review from Loyalsoldier, vcptr and kslr January 27, 2021 17:24

Fix test: remove reference to removed attribute

beb02e7

kslr force-pushed the dev-fakedns branch from b11c5fc to beb02e7 Compare February 8, 2021 00:09

kslr and others added 5 commits February 8, 2021 09:45

Test: fix codacy issue

0d1cea1

Conf: Remove old field support

24949ae

Test: fix codacy issue

d1cdef6

Change test scale for TestFakeDnsHolderCreateMappingAndRollOver

78d3371

Test: fix codacy issue

865771d

kslr merged commit 38da831 into master Feb 8, 2021

Loyalsoldier deleted the dev-fakedns branch February 9, 2021 01:23

RPRX mentioned this pull request Feb 12, 2021

建议加入fake dns功能 XTLS/Xray-core#245

Closed

yuhan6665 mentioned this pull request Feb 20, 2021

Routing and freedom outbound ignore Fake DNS #696

Merged

rurirei mentioned this pull request Feb 21, 2021

panic: V is not in context. #698

Closed

yuhan6665 mentioned this pull request Feb 26, 2021

Fakedns XTLS/Xray-core#309

Merged

dependabot bot mentioned this pull request Mar 8, 2021

Bump github.com/v2fly/v2ray-core/v4 from 4.35.0 to 4.35.1 v2fly/domain-list-community#457

Merged

This was referenced Mar 31, 2021

feat: shouldSniffDomain for (FakeDNS) Sniffer XTLS/Xray-core#436

Closed

feat: shouldSniffDomain for Sniffer #843

Closed

e1732a364fed mentioned this pull request Sep 22, 2022

[Feature Request] fakedns e1732a364fed/v2ray_simple#146

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fake DNS with full V2 intergration #406

Fake DNS with full V2 intergration #406

xiaokangwang commented Nov 11, 2020 •

edited

Loading

yuhan6665 commented Nov 11, 2020

xiaokangwang commented Nov 11, 2020 •

edited

Loading

xiaokangwang commented Nov 11, 2020 •

edited

Loading

yuhan6665 commented Nov 12, 2020

xiaokangwang commented Nov 12, 2020

xiaokangwang commented Nov 12, 2020

rurirei commented Nov 13, 2020

This comment has been minimized.

This comment has been minimized.

kslr commented Dec 2, 2020

xiaokangwang commented Dec 4, 2020

xiaokangwang commented Dec 16, 2020

Loyalsoldier commented Dec 19, 2020

kslr commented Dec 19, 2020

xiaokangwang commented Jan 27, 2021

kslr commented Feb 8, 2021

yuhan6665 commented Feb 8, 2021

kslr commented Feb 8, 2021 •

edited

Loading

yuhan6665 commented Feb 9, 2021 •

edited

Loading

yuhan6665 commented Feb 16, 2021

rurirei commented Feb 19, 2021

Loyalsoldier commented Feb 21, 2021

yuhan6665 commented Feb 21, 2021

Fake DNS with full V2 intergration #406

Fake DNS with full V2 intergration #406

Conversation

xiaokangwang commented Nov 11, 2020 • edited Loading

yuhan6665 commented Nov 11, 2020

xiaokangwang commented Nov 11, 2020 • edited Loading

xiaokangwang commented Nov 11, 2020 • edited Loading

yuhan6665 commented Nov 12, 2020

xiaokangwang commented Nov 12, 2020

xiaokangwang commented Nov 12, 2020

rurirei commented Nov 13, 2020

This comment has been minimized.

This comment has been minimized.

kslr commented Dec 2, 2020

xiaokangwang commented Dec 4, 2020

xiaokangwang commented Dec 16, 2020

Loyalsoldier commented Dec 19, 2020

kslr commented Dec 19, 2020

xiaokangwang commented Jan 27, 2021

kslr commented Feb 8, 2021

yuhan6665 commented Feb 8, 2021

kslr commented Feb 8, 2021 • edited Loading

yuhan6665 commented Feb 9, 2021 • edited Loading

yuhan6665 commented Feb 16, 2021

rurirei commented Feb 19, 2021

Loyalsoldier commented Feb 21, 2021

yuhan6665 commented Feb 21, 2021

xiaokangwang commented Nov 11, 2020 •

edited

Loading

xiaokangwang commented Nov 11, 2020 •

edited

Loading

xiaokangwang commented Nov 11, 2020 •

edited

Loading

kslr commented Feb 8, 2021 •

edited

Loading

yuhan6665 commented Feb 9, 2021 •

edited

Loading