fix timestamp default value #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtopper
reviewed
Sep 24, 2019
| for i, t := range times { | ||
| msg.Times[i] = t.UnixNano() | ||
| if t == nilTime { |
There was a problem hiding this comment.
Might be a good idea to defend against all unsupported values.
There was a problem hiding this comment.
Yea i thought about it.. i dont really think it's gonna have other unsupported values. this only happens when we initialize the times slice with a certain size so the "zero" values or this shitty thing 0001-01-01...
There was a problem hiding this comment.
Not sure why it can't have other unsupported values?
gtopper
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.