Supporting batching resources scaling #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
reviewed
Dec 28, 2019
| @@ -67,7 +67,7 @@ func Run(kubeconfigPath string, | |||
| } | |||
|
|
|||
| func createDLX(resourceScaler scaler_types.ResourceScaler, options scaler_types.DLXOptions) (*dlx.DLX, error) { | |||
| rootLogger, err := nucliozap.NewNuclioZap("dlx", "console", os.Stdout, os.Stderr, nucliozap.DebugLevel) | |||
| rootLogger, err := nucliozap.NewNuclioZap("scaler", "console", os.Stdout, os.Stderr, nucliozap.DebugLevel) | |||
pkg/dlx/dlx.go
Outdated
| resourceScaler scaler_types.ResourceScaler, | ||
| options scaler_types.DLXOptions) (*DLX, error) { | ||
| resourceStarter, err := NewResourceStarter(logger, resourceScaler, options.Namespace, options.ResourceReadinessTimeout) | ||
| childLogger := parentLogger.GetChild("autoscaler") | ||
| childLogger.InfoWith("Creating DLX", |
pkg/dlx/dlx.go
Outdated
| resourceScaler scaler_types.ResourceScaler, | ||
| options scaler_types.DLXOptions) (*DLX, error) { | ||
| resourceStarter, err := NewResourceStarter(logger, resourceScaler, options.Namespace, options.ResourceReadinessTimeout) | ||
| childLogger := parentLogger.GetChild("autoscaler") |
There was a problem hiding this comment.
logger name should be dlx
pkg/dlx/dlx.go
Outdated
| listenAddress: options.ListenAddress, | ||
| handler: handler, | ||
| }, nil | ||
| } | ||
|
|
||
| func (d *DLX) Start() error { | ||
| d.logger.InfoWith("Starting", | ||
| d.logger.DebugWith("Starting", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In each cycle of the autoscaler it will first iterate all resources and check which should be scaled to zero, then will scale to zero all of them together. (before this PR the behavior was to trigger scale to zero on every resource separately)
Added some logs improvements for better readability