Bump k8s go sdk client #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omesser
approved these changes
Jul 2, 2020
Hedingber
approved these changes
Jul 4, 2020
There was a problem hiding this comment.
@liranbg please add in the description the list of changes in this PR (GH actions etc...)
I feel like we should rename metricsGroupName and metricsGroupKind to metricsResourceGroup and metricsResourceKind.
IIUC k8s calls it GroupKind simply because it's the group and the kind, not the group and the kind of the group (it's the kind of the resource)
omesser
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required changes made on
custom_metricsto receive bothGroupandGroupKindin order to use new k8scustom_metrics. Thanks to https://github.com/v3io/scaler-types/pull/9/files it is now possible.GroupKindinstance (as oppose to groupKind as a string)