Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUC-233] Ensure the call to setShardSequenceNumberInPersistency fails for non-existing or non-shard objects. #151

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

alxtkr77
Copy link
Contributor

No description provided.

@assaf758
Copy link
Member

assaf758 commented Aug 26, 2024

Notice that I updated the PR since Condition: "__obj_type == 3" was already in the codebase.
The PR Looks good but regarding checkShardExists (from previous PR) - do we still need it for debugging? I'm asking since I understand from your comment in the jira that nuclio will get 400 if there is update-item before put-record.
If we do need it, I suggest optimizing by maintaining a doCheckShardExist flag in the streamConsumerGroup such that the get-item check will continue until the first time the item was found to exist.

@assaf758 assaf758 merged commit da2a3f6 into v3io:development Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants