Testing becomes impossible

[RafaRuiz]

When having all calls static, testing this is impossible.
Would it be good to create an aside "instance" that starts with an initialization then with that object, you can call anything else?

Example:
Instead of:

Intercom.initialize().then((_) => Intercom.displayMessenger());

I would do:

class Intercom ... 

Intercom._();

static Future<Intercom> initialize(...) { ... }

void displayMessenger() { }
// ... other methods

I can submit a PR for this.

[deepak786]

@RafaRuiz
I don't think that this is necessary. Also, this would be a breaking change.

is there an issue using the static functions?

[RafaRuiz]

It would be a breaking change, but we can go step by step (deprecating).
If all the methods are static, we can't mock them with mockito or mocktail

Imagine I want to mock that the initialization worked but displayMessenger didn't, for some reason. I can't do that with the current implementation

[deepak786]

@Zazo032 what do you think about this?

[Zazo032]

I like the instance approach, Firebase plugins did the same thing, and if it helps on the testing side, I think there are no downsides. However, we should do the addition, deprecation and removal in different releases

[deepak786]

We can't have both static and instance members with the same name dart-lang/language#1711
So to implement the instance approach, we have to delete the static methods.