Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Instance approach #226

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Use Instance approach #226

merged 4 commits into from
Apr 11, 2022

Conversation

deepak786
Copy link
Collaborator

@deepak786 deepak786 commented Apr 11, 2022

fixes #170

It is not possible to keep the static and instance members together with the same name (dart-lang/language#1711) So the only solution is to delete the static methods and have only instance-level methods.

  • version will be 7.0.0
  • changelog will be updated according to the breaking change.

@deepak786 deepak786 requested a review from Zazo032 April 11, 2022 13:24
@deepak786 deepak786 self-assigned this Apr 11, 2022
Copy link
Collaborator

@Zazo032 Zazo032 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as the breaking change is reflected in changelog, I don't think this requires any deprecation. A small migration guide could also help, but the changes should be trivial

@deepak786
Copy link
Collaborator Author

It will be just a small explanation in the changelog.

@deepak786 deepak786 merged commit eebecbd into v3rm0n:master Apr 11, 2022
@deepak786 deepak786 deleted the instance_approach branch April 11, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing becomes impossible
2 participants