Skip to content

Commit

Permalink
Don't use soon-to-be-deprecated V8 Api (#182)
Browse files Browse the repository at this point in the history
Namely v8::FunctionCallbackInfo::Holder(), one should use This()
method instead.
See https://crrev.com/c/5444829 for details.
  • Loading branch information
isheludko authored and pthier committed Jul 15, 2024
1 parent cdc8d69 commit 3a66cfd
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -826,9 +826,9 @@ class from C++.
The JavaScript object can be accessed as a `v8::Local<v8::Object>` by using
`self->object()`, given a `BaseObject` named `self`.

Accessing a `BaseObject` from a `v8::Local<v8::Object>` (frequently that is
`args.This()` in a [binding function][]) can be done using
the `Unwrap<T>(obj)` function, where `T` is a subclass of `BaseObject`.
Accessing a `BaseObject` from a `v8::Local<v8::Object>` (that is `args.This()`
in a [binding function][]) can be done using the `Unwrap<T>(obj)` function,
where `T` is a subclass of `BaseObject`.
A helper for this is the `ASSIGN_OR_RETURN_UNWRAP` macro that returns from the
current function if unwrapping fails (typically that means that the `BaseObject`
has been deleted earlier).
Expand Down

0 comments on commit 3a66cfd

Please sign in to comment.