Make test-http-server-keepalive-req-gc robust to GC heuristics #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isheludko
pushed a commit
to isheludko/node
that referenced
this pull request
Jun 3, 2024
* Fix test-http-server-keepalive-req-gc * Format --------- Co-authored-by: Etienne Pierre-doray <etiennep@chromium.org>
victorgomes
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds a second explicit gc call in the test. Without this call,
the test relies on gc eventually happening based, since the first call
doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics unrelated
to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free the object.