build: fix build error for clang-cl #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to confirm that this patch works and fixes the Clang build on Windows. |
bnoordhuis
reviewed
Apr 30, 2018
src/node_win32_perfctr_provider.h
Outdated
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| namespace node { | |||
|
|
|||
| extern HANDLE NodeCounterProvider; | |||
| EXTERN_C HANDLE NodeCounterProvider; | |||
There was a problem hiding this comment.
It should still be extern here, otherwise including the header in two source files leads to it getting defined twice.
(I guess in practice it ends up in the Windows equivalent of .common and the linker merges them but it's best not to depend on that.)
5 tasks
|
@bnoordhuis do you like the current version better? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang complains that the declaration and definition differs (
externvsextern "C"). This fixes the issue.