-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword arguments to spectrogram #657
Conversation
And for micropython ones too! I was looking for that log component (because of an audio application I'm working on). Plus that RAM-saving scratchpad feature is a good addition too. Please get this merged! ;) |
If you have any comments on the concept itself, please, let me know! This is the best I could come up with, but that doesn't mean that this is the best. |
Sure, fair enough. I just built a runtime with this for esp32s3, tested it and some I'll keep playing with it this and next week and I'll let you know if anything else arises. |
There was a minor conflict when merging with |
The actual conflict is just the version number of There are two possible solutions to this: we either modify the tests in such a way that the difference disappears, or I add the I would prefer the second solution, because it's cleaner, doesn't sweep anything under the rug, and adds a potentially useful feature. I'll just have to find out, how much it costs, although, I believe, it shouldn't be more than 200-300 bytes. |
Details and rationale are outlined in https://github.com/v923z/micropython-ulab/blob/spectrum/docs/ulab-utils.ipynb, but the gist is that
spectrogram
now allows for the re-use of allocated memory (through theout
, andscratchpad
keyword arguments), as well as direct calculation of the logarithm (through thelog
keyword argument).@jepler, @dhalbert this might be relevant for
circuitpython
users.