Separate sprite and entity animations #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasenbanck
force-pushed
the
animation_action_refactor
branch
5 times, most recently
from
4764c64 to
8c89ed8
Compare
This PR separates the action types and the way we render the animations of entities and "actor" sprites like the mouse cursor and the skill icons completely. We also now properly calculate the base offset of entity actions based on the entity type. The workaround for the mouse cursor has also been removed by fixing the underlying problem.
hasenbanck
force-pushed
the
animation_action_refactor
branch
from
8c89ed8 to
2ddb538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the action types and the way we render the animations of entities and "actor" sprites like the mouse cursor and the skill icons completely. We also now properly calculate the base offset of entity actions based on the entity type. The workaround for the mouse cursor has also been removed by fixing the underlying problem.