Port enhanced-grid-flow to vaadin 24 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- vaadin 24.0.0 - jakarta.servlet 6.0.0 - popup 4.0.
- Renderer.getValueProviders() was removed in vaadin 24 and ColumnPathRenderer doesn't expose its ValueProvider in any way.
the super method was removed from Grid in vaadin 24
the super method was removed from Grid.Collumn in vaadin 24
Since the java Drid doesn't have support for custom column's header renderer anymore, I used a somewhat radical approach to the problem: I monkey patched the function that sets the client side header renderer. If a column has a filter, then we will use enhanced-grid-sorter in the header. If the column doesn't have, then the default implementation will be used.
paodb
approved these changes
Mar 30, 2023
This was referenced Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.