Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number fields constructors should allow null as default value #189

Closed
vaadin-miki opened this issue Jul 6, 2020 · 0 comments · Fixed by #192
Closed

Number fields constructors should allow null as default value #189

vaadin-miki opened this issue Jul 6, 2020 · 0 comments · Fixed by #192
Assignees
@vaadin-miki
Labels
api All things related with adding, removing and modifying public API. bug Something isn't working
Milestone
0.7.3 - Null as d...

Comments

@vaadin-miki
Copy link
Owner

Setting null as default value should automatically call setNullValueAllowed to true.
@vaadin-miki vaadin-miki self-assigned this Jul 6, 2020
@vaadin-miki vaadin-miki added the bug Something isn't working label Jul 6, 2020
@vaadin-miki vaadin-miki added this to the Next release milestone Jul 6, 2020
@vaadin-miki vaadin-miki added the api All things related with adding, removing and modifying public API. label Jul 6, 2020
vaadin-miki added a commit that referenced this issue Jul 6, 2020
@vaadin-miki
#189 done, #191 fixed in the process
01c9141
@vaadin-miki vaadin-miki mentioned this issue Jul 6, 2020
Merged
vaadin-miki added a commit that referenced this issue Jul 6, 2020
@vaadin-miki
#189 done, #191 fixed in the process (#192)
7314c22 
added new constructor to number fields that takes default value and label
vaadin-miki added a commit that referenced this issue Jul 6, 2020
@vaadin-miki
Release 0.7.3 ready (#195)
f7374ef 
done #188 #189 and #191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
api All things related with adding, removing and modifying public API. bug Something isn't working
Projects
None yet
Milestone
0.7.3 - Null as default value in numb...
Development

Successfully merging a pull request may close this issue.

#189 done, #191 fixed in the process vaadin-miki/super-fields
1 participant
@vaadin-miki