Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapEntryField has incorrect value after creation #388

Closed
vaadin-miki opened this issue Sep 8, 2022 · 1 comment · Fixed by #397
Closed

MapEntryField has incorrect value after creation #388

vaadin-miki opened this issue Sep 8, 2022 · 1 comment · Fixed by #397
Assignees
@vaadin-miki
Labels
bug Something isn't working
Milestone
0.14.0 - ObjectField

Comments

@vaadin-miki
Copy link
Owner

It seems that null filters for MapField works remarkably well, as the component cannot have any new entries added to it.

Investigate the issue, as it may work as designed (in that new entries may require some default data to start with). If this is the case, modify the demo app and also ensure the documentation is correct.
@vaadin-miki vaadin-miki added the bug Something isn't working label Sep 8, 2022
@vaadin-miki vaadin-miki added this to the Next release milestone Sep 8, 2022
@vaadin-miki vaadin-miki self-assigned this Sep 8, 2022
@vaadin-miki vaadin-miki changed the title MapField with null filter does not allow adding new entries MapEntryField has incorrect value after creation Sep 9, 2022
@vaadin-miki
Copy link
Owner Author

turns out it was MapEntryField that was at fault here, as it kept null as its value after creation and thus not showing any component

vaadin-miki added a commit that referenced this issue Sep 9, 2022
@vaadin-miki
#388 fixed
bbc6c82
@vaadin-miki vaadin-miki mentioned this issue Sep 9, 2022
Merged
vaadin-miki added a commit that referenced this issue Sep 9, 2022
@vaadin-miki
#388 #395 #396 fixed (#397)
c61e4de 
value change now operational in various fields
vaadin-miki added a commit that referenced this issue Sep 9, 2022
@vaadin-miki @dependabot @github-actions
Release 0.14.0 ready (#399)
45464dd 
#382 #380 #387 #390 #391 #386 #388 #395 #396 done

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vaadin-miki <vaadin-miki@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
bug Something isn't working
Projects
None yet
Milestone
0.14.0 - ObjectField
Development

Successfully merging a pull request may close this issue.

#388 #395 #396 fixed vaadin-miki/super-fields
1 participant
@vaadin-miki