Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollectionField and Grid(Multi)Select should implement HasLabel #415

Closed
vaadin-miki opened this issue Sep 23, 2022 · 0 comments · Fixed by #417
Closed

CollectionField and Grid(Multi)Select should implement HasLabel #415

vaadin-miki opened this issue Sep 23, 2022 · 0 comments · Fixed by #417
Assignees
@vaadin-miki
Labels
api All things related with adding, removing and modifying public API. bug Something isn't working
Milestone
0.15.0 - HasPosit...

Comments

@vaadin-miki
Copy link
Owner

it seems that CollectionField, GridSelect and GridMultiSelect do not implement HasLabel, but they should
@vaadin-miki vaadin-miki added bug Something isn't working api All things related with adding, removing and modifying public API. labels Sep 23, 2022
@vaadin-miki vaadin-miki added this to the Next release milestone Sep 23, 2022
@vaadin-miki vaadin-miki self-assigned this Sep 23, 2022
vaadin-miki added a commit that referenced this issue Sep 23, 2022
@vaadin-miki
#414 added support to almost all relevant components
021d8e8 
#415 fixed
@vaadin-miki vaadin-miki mentioned this issue Sep 26, 2022
Merged
vaadin-miki added a commit that referenced this issue Sep 26, 2022
@vaadin-miki
#414 #415 done (#417)
493e252 
HasLabelPositionable done
vaadin-miki added a commit that referenced this issue Sep 26, 2022
@vaadin-miki @dependabot @github-actions
Release 0.15.0 ready (#420)
c181d6e 
* #412 #414 #415 #416 done

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vaadin-miki <vaadin-miki@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
api All things related with adding, removing and modifying public API. bug Something isn't working
Projects
None yet
Milestone
0.15.0 - HasPositionableLabel
Development

Successfully merging a pull request may close this issue.

#414 #415 done vaadin-miki/super-fields
1 participant
@vaadin-miki