This repository has been archived by the owner on Jul 6, 2021. It is now read-only.
Implement RovingTabIndexMixin and 2 other mixins #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
roving-tabindex
branch
2 times, most recently
from
0ec9429 to
06c018a
Compare
web-padawan
changed the title
web-padawan
force-pushed
the
roving-tabindex
branch
from
54ff3e3 to
e141937
Compare
web-padawan
force-pushed
the
roving-tabindex
branch
from
e141937 to
276ef45
Compare
Haprog
approved these changes
Dec 2, 2019
web-padawan
force-pushed
the
roving-tabindex
branch
from
276ef45 to
578c6ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
This PR contains the 3 mixins prototyped at vaadin/vaadin-accordion#30
SlottedItemsMixinKeyboardDirectionMixinRovingTabIndexMixinThey are needed for the following components:
vaadin-accordion: 1 and 2 onlyvaadin-tabs: 1, 2 3vaadin-list-box: 1, 2, 3