Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enhance dialog component documentation with positioning and sizing details #3946

Open
wants to merge 4 commits into
base: latest
Choose a base branch
from

Conversation

DiegoCardoso
Copy link
Contributor

Create new "Position" and "Size" sections and move "Draggable" and "Rezizable" sections to the corresponding ones.

Also add code snippets showing the new API for programmatically sizing and positioning.

@github-actions github-actions bot added the Language unchecked English language check has not been done label Nov 25, 2024
@DiegoCardoso DiegoCardoso marked this pull request as ready for review November 26, 2024 09:22
articles/components/dialog/index.adoc Outdated Show resolved Hide resolved
articles/components/dialog/index.adoc Outdated Show resolved Hide resolved
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
articles/components/dialog/index.adoc Outdated Show resolved Hide resolved
articles/components/dialog/index.adoc Outdated Show resolved Hide resolved
articles/components/dialog/index.adoc Outdated Show resolved Hide resolved
endif::[]
--

The dialog's default size adjusts automatically based on its content. Fixed dimensions could be used when you need precise control over the dialog's size, for example, when displaying a form or grid with specific space requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we can remove this paragraph.

articles/components/dialog/index.adoc Outdated Show resolved Hide resolved
Co-authored-by: Rolf Smeds <rolf@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language unchecked English language check has not been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants