feat: support reverse button collapsing order in menu-bar (#6048) (#6056

)
vaadin · Feb 16, 2024 · a22be12 · a22be12
1 parent 13eb3da
commit a22be12
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 0 deletions.
diff --git a/...-parent/vaadin-menu-bar-flow/src/main/java/com/vaadin/flow/component/menubar/MenuBar.java b/...-parent/vaadin-menu-bar-flow/src/main/java/com/vaadin/flow/component/menubar/MenuBar.java
@@ -387,6 +387,30 @@ public void removeThemeVariants(MenuBarVariant... variants) {
                         .collect(Collectors.toList()));
     }
 
+    /**
+     * Sets reverse collapse order for the menu bar.
+     *
+     * @param reverseCollapseOrder
+     *            If {@code true}, the buttons will be collapsed into the
+     *            overflow menu starting from the "start" end of the bar instead
+     *            of the "end".
+     */
+    public void setReverseCollapseOrder(boolean reverseCollapseOrder) {
+        getElement().setProperty("reverseCollapse", reverseCollapseOrder);
+    }
+
+    /**
+     * Gets whether the menu bar uses reverse collapse order.
+     *
+     * @return {@code true} if the buttons will be collapsed into the overflow
+     *         menu starting from the "start" end of the bar instead of the
+     *         "end".
+     *
+     */
+    public boolean isReverseCollapseOrder() {
+        return getElement().getProperty("reverseCollapse", false);
+    }
+
     /**
      * Gets the internationalization object previously set for this component.
      * <p>

diff --git a/...adin-menu-bar-flow/src/test/java/com/vaadin/flow/component/menubar/tests/MenuBarTest.java b/...adin-menu-bar-flow/src/test/java/com/vaadin/flow/component/menubar/tests/MenuBarTest.java
@@ -85,6 +85,21 @@ public void setOpenOnHover_isOpenOnHover() {
         Assert.assertTrue(menuBar.isOpenOnHover());
     }
 
+    @Test
+    public void isReverseCollapseOrder() {
+        Assert.assertFalse(menuBar.isReverseCollapseOrder());
+        Assert.assertFalse(
+                menuBar.getElement().getProperty("reverseCollapse", false));
+    }
+
+    @Test
+    public void setReverseCollapseOrder_isReverseCollapseOrder() {
+        menuBar.setReverseCollapseOrder(true);
+        Assert.assertTrue(menuBar.isReverseCollapseOrder());
+        Assert.assertTrue(
+                menuBar.getElement().getProperty("reverseCollapse", false));
+    }
+
     private void assertChildrenAndItems(MenuItem... expected) {
         Object[] menuItems = menuBar.getChildren().toArray();
         Assert.assertArrayEquals(expected, menuItems);