Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate client-side validation into DateTimePicker #3527

Merged
merged 28 commits into from
Sep 5, 2022
Merged

feat: integrate client-side validation into DateTimePicker #3527

merged 28 commits into from
Sep 5, 2022

Conversation

DiegoCardoso
Copy link
Contributor

@DiegoCardoso DiegoCardoso commented Jul 28, 2022 •
edited by vursen
Loading

Description

Implement the addValidationStatusChangeListener to trigger Binder validation when validated event is received from the web component.

Depends on

Part of vaadin/platform#3066

Type of change

  • Bugfix
  • Feature

@vursen vursen force-pushed the feat/date-time-picker/validated-event branch 2 times, most recently from 2da4cba to c188689 Compare August 11, 2022 13:37
@vursen vursen force-pushed the feat/date-time-picker/validated-event branch 2 times, most recently from 8231622 to cbe22e3 Compare September 1, 2022 13:36
DiegoCardoso and others added 20 commits September 1, 2022 17:29
@vursen vursen force-pushed the feat/date-time-picker/validated-event branch from 0068edd to d0d15e8 Compare September 1, 2022 14:33
@vursen vursen marked this pull request as ready for review September 2, 2022 11:55
@vursen vursen enabled auto-merge (squash) September 5, 2022 06:30
@vursen vursen disabled auto-merge September 5, 2022 06:33
@vursen vursen enabled auto-merge (squash) September 5, 2022 06:33
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 26 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen merged commit 0f4356f into master Sep 5, 2022
@vursen vursen deleted the feat/date-time-picker/validated-event branch September 5, 2022 06:41
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.

@mukherjeesudebi mukherjeesudebi mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen left review comments

@yuriy-fix yuriy-fix yuriy-fix approved these changes

Assignees
No one assigned
Labels
Released with Vaadin 23.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DiegoCardoso @vaadin-bot @vursen @yuriy-fix