Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for input value populated state (WIP) #3550

Conversation

yuriy-fix
Copy link
Contributor

No description provided.

@yuriy-fix yuriy-fix force-pushed the feat/date-field/validate-input-value branch from 7f7eebf to 417a5bf Compare August 4, 2022 11:28
@vaadin vaadin deleted a comment from vaadin-bot Aug 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

* <code>false</code> otherwise
*/
@Synchronize(property = "_hasInputValue", value = "has-input-value-changed")
private boolean getInputValuePopulated() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we name it hasInputValue?

@vursen vursen force-pushed the feat/date-field/validated-event branch 3 times, most recently from c7f770b to 2361545 Compare August 11, 2022 15:04
@vursen
Copy link
Contributor

vursen commented Aug 15, 2022

Closing as the suggested approach is now implemented for DatePicker and TimePicker in their individual PRs:

@vursen vursen closed this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants