Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add keepFilter option #5953

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: add keepFilter option #5953

merged 1 commit into from
Jan 15, 2024

Conversation

sissbruecker
Copy link
Contributor

Description

Adds Flow API for the new multi-select combo box keepFilter option.

Closes vaadin/web-components#5930

WC PR: vaadin/web-components#7063

Type of change

  • Feature

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sissbruecker sissbruecker merged commit ff5c995 into main Jan 15, 2024
5 checks passed
@sissbruecker sissbruecker deleted the feat/mscb-keep-filter branch January 15, 2024 13:14
@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @sissbruecker, when i performed cherry-pick to this commit to 23.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick ff5c995
error: could not apply ff5c995... feat: add keepFilter option (#5953)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

sissbruecker added a commit that referenced this pull request Jan 15, 2024
@sissbruecker
feat: add keepFilter option (#5953)
bec9a7c 
Cherry-pick of #5953
@sissbruecker sissbruecker mentioned this pull request Jan 15, 2024
Merged
sissbruecker added a commit that referenced this pull request Jan 15, 2024
@sissbruecker
feat: add keepFilter option (#5953) (CP: 23.4) (#5954)
f166581 
* feat: add keepFilter option (#5953)

Cherry-pick of #5953

* update since annotation

* remove check for non-existing property
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha2 and is also targeting the upcoming stable 24.4.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.4.0.alpha2 and is also targeting the upcoming stable 23.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

@DiegoCardoso DiegoCardoso Awaiting requested review from DiegoCardoso

Assignees
No one assigned
Labels
need to pick manually 23.4 prerelease version for Vaadin 23.4.0 prerelease version for Vaadin 24.4.0 Released with Vaadin 23.4.0.alpha2 Released with Vaadin 24.4.0.alpha2 target/23.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiselection at once for Multiselect Combobox
3 participants
@sissbruecker @vaadin-bot @vursen