feat: add target API to SideNavItem #5962
Conversation
DiegoCardoso
force-pushed
the
feat/side-nav/target-api
branch
2 times, most recently
from
4fb2992
to
ff45bb3
Compare
DiegoCardoso
force-pushed
the
feat/side-nav/target-api
branch
from
ff45bb3
to
5d6f2d3
Compare
| * true if the target URL should be opened in a new browser tab, | ||
| * false otherwise | ||
| */ | ||
| public void setOpenInNewBrowserTab(boolean openInNewBrowserTab) { |
There was a problem hiding this comment.
Browser is maybe a bit redundant? setOpenInNewTab would be enough IMO.
There was a problem hiding this comment.
The name has been taken from the AC ticket: vaadin/platform#4850
(ping @rolfsmeds)
There was a problem hiding this comment.
Tab could be confused with <vaadin-tab>.
Even "browser tab" is a bit misleading, as it could just as well be a window (depending on your browser settings). Not sure if openInNewWindow would be any less misleading?
There was a problem hiding this comment.
setOpenInNewBrowsingContext would be the most technically correct terminology, I guess, but very unintuitive to most developers.
There was a problem hiding this comment.
Window seems more misleading to me since opening in a new tab is the default behavior in most browsers.
I agree that Context is unintuitive.
|
|
This ticket/PR has been released with Vaadin 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version. |
Description
Add two new API for setting/getting the
targetproperty of aSideNavItem, whose value is used to set thetargetattribute in the internal anchor element inside the web-component:setTarget(String)/getTarget()- which receives any string as argumentsetOpenInNewBrowserTab(boolean)/isOpenInNewBrowserTab()- a convenience method that internally callssetTargetwith_blankas value when called withtrue.Depends on vaadin/web-components#7088
Fixes #5091
AC vaadin/platform#4850
Type of change