-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add required state and validation support to Checkbox #6167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
changed the title
feat: add basic validation support to Checkbox
feat: add required state and validation support to Checkbox
Apr 3, 2024
web-padawan
force-pushed
the
feat/checkbox-validation
branch
from
April 10, 2024 13:16
59a9a13
to
8d81583
Compare
web-padawan
force-pushed
the
feat/checkbox-validation
branch
3 times, most recently
from
April 15, 2024 11:13
6c58cf1
to
3eea424
Compare
vursen
reviewed
Apr 15, 2024
...w-parent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox/Checkbox.java
Outdated
Show resolved
Hide resolved
vursen
reviewed
Apr 15, 2024
...in/java/com/vaadin/flow/component/checkbox/tests/validation/CheckboxBasicValidationPage.java
Outdated
Show resolved
Hide resolved
vursen
approved these changes
Apr 15, 2024
web-padawan
force-pushed
the
feat/checkbox-validation
branch
from
April 15, 2024 13:34
8208ee5
to
0d46f18
Compare
web-padawan
force-pushed
the
feat/checkbox-validation
branch
from
April 16, 2024 06:48
0d46f18
to
bcd421a
Compare
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.4.0.alpha22 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of vaadin/platform#5190
Depends on vaadin/web-components#7285
Type of change