test: add a test for item click on edit column cell #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
May 29, 2024
Comment on lines
150
to
156
| GridTHTDElement cell = grid.getCell(0, 2); | ||
| cell.click(); | ||
|
|
||
| assertCellEnterEditModeOnDoubleClick(0, 2, "vaadin-combo-box"); | ||
| String eventsPanelText = getPanelText("events-panel"); | ||
| Assert.assertEquals(1, eventsPanelText.split("ItemClicked").length - 1); | ||
| Assert.assertTrue(eventsPanelText |
There was a problem hiding this comment.
nit: Could the test be made slightly stricter?
Suggested change
| GridTHTDElement cell = grid.getCell(0, 2); | |
| cell.click(); | |
| assertCellEnterEditModeOnDoubleClick(0, 2, "vaadin-combo-box"); | |
| String eventsPanelText = getPanelText("events-panel"); | |
| Assert.assertEquals(1, eventsPanelText.split("ItemClicked").length - 1); | |
| Assert.assertTrue(eventsPanelText | |
| GridTHTDElement cell = grid.getCell(0, 2); | |
| cell.click(); | |
| Assert.assertEquals(1, eventsPanelText.split("ItemClicked").length - 1); | |
| assertCellEnterEditModeOnDoubleClick(0, 2, "vaadin-combo-box"); | |
| String eventsPanelText = getPanelText("events-panel"); | |
| Assert.assertEquals(1, eventsPanelText.split("ItemClicked").length - 1); | |
| Assert.assertTrue(eventsPanelText |
There was a problem hiding this comment.
That assertCellEnterEditModeOnDoubleClick line serves no purpose in the test at all. The helper method doesn't actually perform a double-click on the line but dispatches a "dblclick" event manually.
Removed the accidental line altogether since it isn't related to the test case. An actual double-click on the row would dispatch 2 additional item click listener invocations.
vursen
approved these changes
May 29, 2024
DiegoCardoso
approved these changes
May 29, 2024
|
vursen
approved these changes
May 29, 2024
web-padawan
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a test case to verify vaadin/web-components#7453 fixes the item click listener regression in Grid Pro which manifested after this addition to the grid connector.
Related to vaadin/web-components#637
Type of change
Tests