Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use new sizing API in Dialog #6783

Merged
merged 3 commits into from
Nov 5, 2024
Merged

refactor: use new sizing API in Dialog #6783

merged 3 commits into from
Nov 5, 2024

Conversation

DiegoCardoso
Copy link
Contributor

Description

Refactor the sizing API to use the height and width properties introduced in the web component

Part of vaadin/web-components#1060

Type of change

  • Feature

@DiegoCardoso DiegoCardoso enabled auto-merge (squash) November 5, 2024 11:45
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DiegoCardoso DiegoCardoso merged commit 7a78e53 into main Nov 5, 2024
5 checks passed
@DiegoCardoso DiegoCardoso deleted the feat/dialog/sizing-api branch November 5, 2024 11:57
@DiegoCardoso DiegoCardoso mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiegoCardoso @sissbruecker