refactor: do not rely on _hasInputValue for detecting bad input #6846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
refactor/update-to-not-use-has-input-value
branch
from
1d0b99e to
09563b9
Compare
vursen
force-pushed
the
refactor/update-to-not-use-has-input-value
branch
from
09563b9 to
b6132ac
Compare
vursen
force-pushed
the
refactor/update-to-not-use-has-input-value
branch
from
6b02a72 to
980e67c
Compare
vursen
changed the title
vursen
changed the title
|
web-padawan
approved these changes
Nov 21, 2024
1 task
sissbruecker
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR follows up on #6743 and updates TimePicker and BigDecimalField to not rely on
_hasInputValuefor detecting bad input. This change will allow us to remove some overrides in the date-picker and time-picker web components.Part of vaadin/web-components#5639
Type of change