Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Theme Editor integration tests #17313

Closed
MarcinVaadin opened this issue Jul 28, 2023 · 1 comment · Fixed by #17404
Closed

Create Theme Editor integration tests #17313

MarcinVaadin opened this issue Jul 28, 2023 · 1 comment · Fixed by #17404
Assignees
@szolo
Labels
prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.alpha8 Theme Editor

Comments

@MarcinVaadin
Copy link
Member

MarcinVaadin commented Jul 28, 2023 •
edited
Loading

Theme Editor should be covered with integration tests to be aware if component structure has changed and Theme Editor rules become outdated.

Inside flow-tests there are different tests, some of them are testing frontend, we just need to clone one of existing test projects and put some Theme Editor logic for testing.

Good starting point would be to:

  1. Pick component
  2. Parse existing metadata file to get properties
  3. Set editor values
  4. Compare CSS rules if they contain metadata rules

Please remember to add test project to computeMatrix.js to make it run on CI.
szolo added a commit that referenced this issue Aug 9, 2023
@szolo
feat: introduce Theme Editor tests
9d6a4ba 
Create test module for a Theme Editor.

Fixes #17313
@szolo szolo mentioned this issue Aug 9, 2023
Merged
9 tasks
@szolo szolo self-assigned this Aug 19, 2023
szolo added a commit that referenced this issue Aug 23, 2023
@szolo
feat: introduce Theme Editor tests
fd3254d 
Create test module for a Theme Editor.

Fixes #17313
szolo added a commit that referenced this issue Aug 23, 2023
@szolo
feat: introduce Theme Editor tests
460e59f 
Create test module for a Theme Editor.

Fixes #17313
szolo added a commit that referenced this issue Aug 24, 2023
@szolo
feat: introduce Theme Editor tests (#17404)
c0803fb 
Create test module for a Theme Editor.

Fixes #17313
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha8 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szolo szolo

Labels
prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.alpha8 Theme Editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce Theme Editor tests vaadin/flow
3 participants
@szolo @vaadin-bot @MarcinVaadin