-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComponentTracker is very slow #18130
Comments
I tried locally with 100 selects with 1000 items and component renderer as suggested. |
Anyway, it should be safe to add a configuration property to disable ComponentTracker in dev mode |
Thanks for your investigation. As you mentionned it's taking less than an ms for each call but called 100k times, it's starting to feel like 10 to 60 seconds for the page to load, when compared with the production mode which is around 2 to 3s. |
Adds a configuration parameter that allows developers to disable component tracking. Fixes #18130
Adds a configuration parameter that allows developers to disable component tracking. Fixes #18130
* docs: add instructions to disable component tracker Part of vaadin/flow#18130 * Apply suggestions from code review Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> * apply review suggestions * First pass at editing touched files. * Second pass at editing touched files. --------- Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> Co-authored-by: russelljtdyer <6652767+russelljtdyer@users.noreply.github.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
* docs: add instructions to disable component tracker Part of vaadin/flow#18130 * Apply suggestions from code review Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> * apply review suggestions * First pass at editing touched files. * Second pass at editing touched files. --------- Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> Co-authored-by: russelljtdyer <6652767+russelljtdyer@users.noreply.github.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
* docs: add instructions to disable component tracker Part of vaadin/flow#18130 * Apply suggestions from code review * apply review suggestions * First pass at editing touched files. * Second pass at editing touched files. --------- Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> Co-authored-by: russelljtdyer <6652767+russelljtdyer@users.noreply.github.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Adds a configuration parameter that allows developers to disable component tracking. Fixes #18130
Description of the bug
When using Vaadin > 24 is dev mode, the ComponentTracker is very slow which make the whole application very slow.
This is annoying most of the time for very low reward (knowing where the component has been created/attached is helpful just a few times during development).
This is also very noticable when using JProfiler because the recording streches up all superficial calls (see attachment)
Expected behavior
The most practical way I see it is by adding a property to avoid the tracking, in addition to the productionMode.
This would solve the performance issue if needed by the developer, and would also still allow other to continue the tracking.
Minimal reproducible example
The best way is to create a page with ~100 select containing each ~1000 elements with custom renderer (this is not my case but this would trigger the performance issue)
Versions
The text was updated successfully, but these errors were encountered: