-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert tsconfig.json change to avoid needing a manual upgrade step in projects #9144
Comments
Adding A different approach would be adding |
@vlukashov That sounds like a better solution. Thanks for the insights! I guess we can still use this issue to fix it (revert changes to tsconfig and add the lib reference comment to |
Revert adding lib section to tsconfig.json to avoid needing a manual upgrade step in projects. Fixes #9144
Since #9109 the
feature/offline
branch uses TS in the service worker and needs to have"lib": ["webworker"]
intsconfig.json
to avoid randomly failing webpack build. However we have no mechanism (at least currently) to do any updates to existingtsconfig.json
in the project so we need to at least make sure to include this information in release notes as upgrade instructions, otherwise when upgrading to this version the webpack build will start failing randomly if you don't make this update to tsconfig.The text was updated successfully, but these errors were encountered: