Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade default npm to 10.2.1 #17898

Closed
wants to merge 1 commit into from
Closed

chore: Upgrade default npm to 10.2.1 #17898

wants to merge 1 commit into from

Conversation

tltv
Copy link
Member

@tltv tltv commented Oct 24, 2023 •
edited
Loading

Fixes: #17874

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Test Results

1 015 files  ±  0  1 015 suites  ±0   1h 2m 42s ⏱️ - 1m 16s
6 510 tests ±  0  6 469 ✔️ ±  0  41 💤 ±0  0 ❌ ±0 
6 744 runs   - 22  6 698 ✔️  - 20  46 💤  - 2  0 ❌ ±0 

Results for commit 7b8e271. ± Comparison against base commit 66cec66.

♻️ This comment has been updated with latest results.

caalador
caalador reviewed Oct 25, 2023
View reviewed changes
flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendTools.java
@@ -70,7 +70,7 @@ public class FrontendTools {
/**
* This is the version shipped with the default Node version.
*/
public static final String DEFAULT_NPM_VERSION = "10.1.0";
public static final String DEFAULT_NPM_VERSION = "10.2.1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will always fail the test installNode_NodeIsInstalledToTargetDirectory as the npm version supplied by node 20.8.1 (and 20.9.0) is 10.1.0
Event the current node version 21.1.0 only brings in npm 10.2.0
I don't think we have a feature for updating the npm installation after node installation.

@tltv
Copy link
Member Author

tltv commented Oct 25, 2023

Need to wait that this npm/cli#6835 gets to the next LTS node 20 release, and both node and npm default versions has to be then updated at the same time in FrontendTools based on this release table.

Other options would be to update to latest node 21 but this was already decided otherwise here #17877.

@mshabarov
Copy link
Contributor

Waits for nodejs/node#50376

@Artur-
Copy link
Member

Artur- commented Nov 23, 2023

This was upgraded in #18111

@Artur- Artur- closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador left review comments

Assignees
No one assigned
Labels
external dependency +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building in CI behind proxy not working with Vaadin 24.2.0
5 participants
@tltv @mshabarov @Artur- @caalador @vaadin-bot