-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Section and IFrame implements HasAriaLabel #18590
Conversation
Test Results1 092 files ± 0 1 092 suites ±0 1h 18m 50s ⏱️ - 1m 36s Results for commit 465d6cc. ± Comparison against base commit 965b10d. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
@jcgueriaud1 The change looks good to me. Do you mind formatting the code as described in #18590 (comment)? |
I pushed the changes for the format |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This ticket/PR has been released with Vaadin 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version. |
Description
Please list all relevant dependencies in this section and provide summary of the change, motivation and context.
Fixes #17876 (issue)
Type of change
Checklist
Additional for
Feature
type of change