Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Section and IFrame implements HasAriaLabel #18590

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Conversation

jcgueriaud1
Copy link
Contributor

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes #17876 (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

github-actions bot commented Feb 1, 2024

Test Results

1 092 files  ± 0  1 092 suites  ±0   1h 18m 50s ⏱️ - 1m 36s
6 837 tests + 1  6 791 ✅ + 1  46 💤 ±0  0 ❌ ±0 
7 178 runs   - 14  7 120 ✅  - 14  58 💤 ±0  0 ❌ ±0 

Results for commit 465d6cc. ± Comparison against base commit 965b10d.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
com.vaadin.flow.component.html.SectionTest ‑ testHasAriaLabelIsNotImplemented
com.vaadin.flow.component.html.IFrameTest ‑ testHasAriaLabelIsImplemented
com.vaadin.flow.component.html.SectionTest ‑ testHasAriaLabelIsImplemented

♻️ This comment has been updated with latest results.

@mcollovati mcollovati added the Contribution PRs coming from the community or external to the team label Feb 2, 2024
mcollovati
mcollovati previously approved these changes Feb 2, 2024
@mcollovati
Copy link
Collaborator

@jcgueriaud1 The change looks good to me. Do you mind formatting the code as described in #18590 (comment)?
Otherwise, I can do it if you're busy

@jcgueriaud1
Copy link
Contributor Author

I pushed the changes for the format

Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vaadin-bot vaadin-bot added +0.1.0 and removed +1.0.0 labels Feb 2, 2024
@mcollovati mcollovati merged commit f8f74e6 into main Feb 2, 2024
25 of 26 checks passed
@mcollovati mcollovati deleted the issues/17876 branch February 2, 2024 12:12
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement HasAriaLabel for html elements with a landmark role
3 participants