-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade minimum supported Gradle version to 8.4 #18683
Conversation
I keep forgetting what the |
This is proposed to be applied to Vaadin 24.4 and we should update minimal requirement for Gradle from 7 to 8, see #18683
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VaadinSmokeTest.pluginShouldFailWithUnsupportedGradleVersion
should be updated as well
There is a failure at Line 31 in 43aab7c
|
The test ensures that gradle plugin works in MPR projects, in combination with the com.devsoap.plugin.vaadin gradle plugin that is for Vaadin 8. So I think it means that after this upgrade we cannot support gradle anymore in MPR projects (or we need to fork the project and maintain it by our own) |
As discussed on Slack, let's not rely on the deprecated com.devsoap.plugin.vaadin. If MPR + Gradle is requested in the future, we can consider re-introducing the support (e.g., by updating com.devsoap.plugin.vaadin). |
Quality Gate passedIssues Measures |
This is proposed to be applied to Vaadin 24.4 and we should update minimal requirement for Gradle from 7 to 8, see #18683
This ticket/PR has been released with Vaadin 24.4.0. |
Close vaadin/platform#5027.
Related to #18367.