Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade minimum supported Gradle version to 8.4 #18683

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

tarekoraby
Copy link
Contributor

Close vaadin/platform#5027.

Related to #18367.

@tarekoraby
Copy link
Contributor Author

I keep forgetting what the +0.0.1 label is supposed to signify. But just to clarify, this change should be in the next Minor (not 24.3)

Copy link

github-actions bot commented Feb 13, 2024

Test Results

1 094 files  ± 0  1 094 suites  ±0   1h 17m 34s ⏱️ - 5m 13s
6 868 tests ± 0  6 822 ✅ ± 0  46 💤 ±0  0 ❌ ±0 
7 189 runs   - 30  7 131 ✅  - 30  58 💤 ±0  0 ❌ ±0 

Results for commit 168c317. ± Comparison against base commit 0a99f4a.

♻️ This comment has been updated with latest results.

mshabarov added a commit that referenced this pull request Feb 13, 2024
This is proposed to be applied to Vaadin 24.4 and we should update minimal requirement for Gradle from 7 to 8, see #18683
Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VaadinSmokeTest.pluginShouldFailWithUnsupportedGradleVersion should be updated as well

@tarekoraby
Copy link
Contributor Author

There is a failure at

. I don't understand what's wrong nor how to fix it.

@mcollovati
Copy link
Collaborator

mcollovati commented Feb 13, 2024

I don't understand what's wrong nor how to fix it.

The test ensures that gradle plugin works in MPR projects, in combination with the com.devsoap.plugin.vaadin gradle plugin that is for Vaadin 8.
However, the Vaadin 8 compatible plugin is not maintained anymore, and it looks like it cannot run with Gradle 8.

So I think it means that after this upgrade we cannot support gradle anymore in MPR projects (or we need to fork the project and maintain it by our own)

@tarekoraby
Copy link
Contributor Author

As discussed on Slack, let's not rely on the deprecated com.devsoap.plugin.vaadin. If MPR + Gradle is requested in the future, we can consider re-introducing the support (e.g., by updating com.devsoap.plugin.vaadin).

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mcollovati mcollovati merged commit 90eddb9 into main Feb 14, 2024
26 checks passed
@mcollovati mcollovati deleted the tarekoraby-patch-2 branch February 14, 2024 10:48
mcollovati pushed a commit that referenced this pull request Feb 14, 2024
This is proposed to be applied to Vaadin 24.4 and we should update minimal requirement for Gradle from 7 to 8, see #18683
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Gradle 7
3 participants