feat: record support in json serializer (#16879) #19258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knoobie
reviewed
Apr 25, 2024
flow-server/src/test/java/com/vaadin/flow/internal/JsonSerializerTest.java
Show resolved
Hide resolved
|
Still need record support in |
caalador
previously approved these changes
Apr 26, 2024
| for (PropertyDescriptor pd : info.getPropertyDescriptors()) { | ||
| if ("class".equals(pd.getName())) { | ||
| continue; | ||
| var type = bean.getClass(); |
There was a problem hiding this comment.
nit: I still don't like var as it obscures the code. Did take 3 looks to get to the end result of Class...
Not that big of an issue now that our min JDK supports it.
There was a problem hiding this comment.
True. Maybe I'll change those vars since they are not used in this class otherwise.
caalador
approved these changes
Apr 26, 2024
|
|
This ticket/PR has been released with Vaadin 24.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16879